CVE-2016-10130

The http_connect function in transports/http.c in libgit2 before 0.24.6 and 0.25.x before 0.25.1 might allow man-in-the-middle attackers to spoof servers by leveraging clobbering of the error variable.

Weakness

The product does not restrict or incorrectly restricts access to a resource from an unauthorized actor.

Affected Software

Extended Description

Access control involves the use of several protection mechanisms such as:

When any mechanism is not applied or otherwise fails, attackers can compromise the security of the product by gaining privileges, reading sensitive information, executing commands, evading detection, etc. There are two distinct behaviors that can introduce access control weaknesses:

Potential Mitigations

• Compartmentalize the system to have “safe” areas where trust boundaries can be unambiguously drawn. Do not allow sensitive data to go outside of the trust boundary and always be careful when interfacing with a compartment outside of the safe area.
• Ensure that appropriate compartmentalization is built into the system design, and the compartmentalization allows for and reinforces privilege separation functionality. Architects and designers should rely on the principle of least privilege to decide the appropriate time to use privileges and the time to drop privileges.

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/19.html
• https://cwe.mitre.org/data/definitions/441.html
• https://cwe.mitre.org/data/definitions/478.html
• https://cwe.mitre.org/data/definitions/479.html
• https://cwe.mitre.org/data/definitions/502.html
• https://cwe.mitre.org/data/definitions/503.html
• https://cwe.mitre.org/data/definitions/536.html
• https://cwe.mitre.org/data/definitions/546.html
• https://cwe.mitre.org/data/definitions/550.html
• https://cwe.mitre.org/data/definitions/551.html
• https://cwe.mitre.org/data/definitions/552.html
• https://cwe.mitre.org/data/definitions/556.html
• https://cwe.mitre.org/data/definitions/558.html
• https://cwe.mitre.org/data/definitions/562.html
• https://cwe.mitre.org/data/definitions/563.html
• https://cwe.mitre.org/data/definitions/564.html
• https://cwe.mitre.org/data/definitions/578.html

References

• http://lists.opensuse.org/opensuse-updates/2017-02/msg00030.html
• http://lists.opensuse.org/opensuse-updates/2017-02/msg00036.html
• http://lists.opensuse.org/opensuse-updates/2017-02/msg00072.html
• http://www.openwall.com/lists/oss-security/2017/01/10/5
• http://www.openwall.com/lists/oss-security/2017/01/11/6
• http://www.securityfocus.com/bid/95359
• https://github.com/libgit2/libgit2/commit/9a64e62f0f20c9cf9b2e1609f037060eb2d8eb22
• https://github.com/libgit2/libgit2/commit/b5c6a1b407b7f8b952bded2789593b68b1876211
• https://libgit2.github.com/security/