CVE-2018-5382

The default BKS keystore use an HMAC that is only 16 bits long, which can allow an attacker to compromise the integrity of a BKS keystore. Bouncy Castle release 1.47 changes the BKS format to a format which uses a 160 bit HMAC instead. This applies to any BKS keystore generated prior to BC 1.47. For situations where people need to create the files for legacy reasons a specific keystore type BKS-V1 was introduced in 1.49. It should be noted that the use of BKS-V1 is discouraged by the library authors and should only be used where it is otherwise safe to do so, as in where the use of a 16 bit checksum for the file integrity check is not going to cause a security issue in itself.

Weakness

The product uses a broken or risky cryptographic algorithm or protocol.

Affected Software

Extended Description

Cryptographic algorithms are the methods by which data is scrambled to prevent observation or influence by unauthorized actors. Insecure cryptography can be exploited to expose sensitive information, modify data in unexpected ways, spoof identities of other users or devices, or other impacts. It is very difficult to produce a secure algorithm, and even high-profile algorithms by accomplished cryptographic experts have been broken. Well-known techniques exist to break or weaken various kinds of cryptography. Accordingly, there are a small number of well-understood and heavily studied algorithms that should be used by most products. Using a non-standard or known-insecure algorithm is dangerous because a determined adversary may be able to break the algorithm and compromise whatever data has been protected. Since the state of cryptography advances so rapidly, it is common for an algorithm to be considered “unsafe” even if it was once thought to be strong. This can happen when new attacks are discovered, or if computing power increases so much that the cryptographic algorithm no longer provides the amount of protection that was originally thought. For a number of reasons, this weakness is even more challenging to manage with hardware deployment of cryptographic algorithms as opposed to software implementation. First, if a flaw is discovered with hardware-implemented cryptography, the flaw cannot be fixed in most cases without a recall of the product, because hardware is not easily replaceable like software. Second, because the hardware product is expected to work for years, the adversary’s computing power will only increase over time.

Potential Mitigations

• When there is a need to store or transmit sensitive data, use strong, up-to-date cryptographic algorithms to encrypt that data. Select a well-vetted algorithm that is currently considered to be strong by experts in the field, and use well-tested implementations. As with all cryptographic mechanisms, the source code should be available for analysis.
• For example, US government systems require FIPS 140-2 certification [REF-1192].
• Do not develop custom or private cryptographic algorithms. They will likely be exposed to attacks that are well-understood by cryptographers. Reverse engineering techniques are mature. If the algorithm can be compromised if attackers find out how it works, then it is especially weak.
• Periodically ensure that the cryptography has not become obsolete. Some older algorithms, once thought to require a billion years of computing time, can now be broken in days or hours. This includes MD4, MD5, SHA1, DES, and other algorithms that were once regarded as strong. [REF-267]
• Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.
• Industry-standard implementations will save development time and may be more likely to avoid errors that can occur during implementation of cryptographic algorithms. Consider the ESAPI Encryption feature.

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/20.html
• https://cwe.mitre.org/data/definitions/459.html
• https://cwe.mitre.org/data/definitions/473.html
• https://cwe.mitre.org/data/definitions/475.html
• https://cwe.mitre.org/data/definitions/608.html
• https://cwe.mitre.org/data/definitions/614.html
• https://cwe.mitre.org/data/definitions/97.html

References

• http://www.securityfocus.com/bid/103453
• https://access.redhat.com/errata/RHSA-2018:2927
• https://www.bouncycastle.org/releasenotes.html
• https://www.kb.cert.org/vuls/id/306792
• https://www.oracle.com/security-alerts/cpuoct2020.html
• http://www.securityfocus.com/bid/103453
• https://access.redhat.com/errata/RHSA-2018:2927
• https://www.bouncycastle.org/releasenotes.html
• https://www.kb.cert.org/vuls/id/306792
• https://www.oracle.com/security-alerts/cpuoct2020.html