CVE-2020-5260

Affected versions of Git have a vulnerability whereby Git can be tricked into sending private credentials to a host controlled by an attacker. Git uses external credential helper programs to store and retrieve passwords or other credentials from secure storage provided by the operating system. Specially-crafted URLs that contain an encoded newline can inject unintended values into the credential helper protocol stream, causing the credential helper to retrieve the password for one server (e.g., good.example.com) for an HTTP request being made to another server (e.g., evil.example.com), resulting in credentials for the former being sent to the latter. There are no restrictions on the relationship between the two, meaning that an attacker can craft a URL that will present stored credentials for any host to a host of their choosing. The vulnerability can be triggered by feeding a malicious URL to git clone. However, the affected URLs look rather suspicious; the likely vector would be through systems which automatically clone URLs not visible to the user, such as Git submodules, or package systems built around Git. The problem has been patched in the versions published on April 14th, 2020, going back to v2.17.x. Anyone wishing to backport the change further can do so by applying commit 9a6bbee (the full release includes extra checks for git fsck, but that commit is sufficient to protect clients against the vulnerability). The patched versions are: 2.17.4, 2.18.3, 2.19.4, 2.20.3, 2.21.2, 2.22.3, 2.23.2, 2.24.2, 2.25.3, 2.26.1.

Weakness

The product receives input or data, but it does not validate or incorrectly validates that the input has the properties that are required to process the data safely and correctly.

Affected Software

Name	Vendor	Start Version	End Version
Git	Git	*	2.17.4 (excluding)
Git	Git	2.22.0 (including)	2.22.3 (excluding)
Git	Git-scm	2.18.0 (including)	2.18.3 (excluding)
Git	Git-scm	2.19.0 (including)	2.19.4 (excluding)
Git	Git-scm	2.20.0 (including)	2.20.3 (excluding)
Git	Git-scm	2.21.0 (including)	2.21.2 (excluding)
Git	Git-scm	2.23.0 (including)	2.23.2 (excluding)
Git	Git-scm	2.24.0 (including)	2.24.2 (excluding)
Git	Git-scm	2.25.0 (including)	2.25.3 (excluding)
Git	Git-scm	2.26.0 (including)	2.26.1 (excluding)
Red Hat Enterprise Linux 7	RedHat	git-0:1.8.3.1-22.el7_8	*
Red Hat Enterprise Linux 7.7 Extended Update Support	RedHat	git-0:1.8.3.1-23.el7_7	*
Red Hat Enterprise Linux 8	RedHat	git-0:2.18.2-2.el8_1	*
Red Hat Enterprise Linux 8.0 Update Services for SAP Solutions	RedHat	git-0:2.18.2-2.el8_0	*
Red Hat Software Collections for Red Hat Enterprise Linux 7	RedHat	rh-git218-git-0:2.18.2-3.el7	*
Red Hat Software Collections for Red Hat Enterprise Linux 7.5 EUS	RedHat	rh-git218-git-0:2.18.2-3.el7	*
Red Hat Software Collections for Red Hat Enterprise Linux 7.6 EUS	RedHat	rh-git218-git-0:2.18.2-3.el7	*
Red Hat Software Collections for Red Hat Enterprise Linux 7.7 EUS	RedHat	rh-git218-git-0:2.18.2-3.el7	*
Git	Ubuntu	bionic	*
Git	Ubuntu	devel	*
Git	Ubuntu	eoan	*
Git	Ubuntu	esm-infra/bionic	*
Git	Ubuntu	esm-infra/xenial	*
Git	Ubuntu	trusty	*
Git	Ubuntu	xenial	*

Extended Description

Input validation is a frequently-used technique for checking potentially dangerous inputs in order to ensure that the inputs are safe for processing within the code, or when communicating with other components. Input can consist of:

Data can be simple or structured. Structured data can be composed of many nested layers, composed of combinations of metadata and raw data, with other simple or structured data. Many properties of raw data or metadata may need to be validated upon entry into the code, such as:

Implied or derived properties of data must often be calculated or inferred by the code itself. Errors in deriving properties may be considered a contributing factor to improper input validation.

Potential Mitigations

Assume all input is malicious. Use an “accept known good” input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does.
When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, “boat” may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as “red” or “blue.”
Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code’s environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.
For any security checks that are performed on the client side, ensure that these checks are duplicated on the server side, in order to avoid CWE-602. Attackers can bypass the client-side checks by modifying values after the checks have been performed, or by changing the client to remove the client-side checks entirely. Then, these modified values would be submitted to the server.
Even though client-side checks provide minimal benefits with respect to server-side security, they are still useful. First, they can support intrusion detection. If the server receives input that should have been rejected by the client, then it may be an indication of an attack. Second, client-side error-checking can provide helpful feedback to the user about the expectations for valid input. Third, there may be a reduction in server-side processing time for accidental input errors, although this is typically a small savings.
Inputs should be decoded and canonicalized to the application’s current internal representation before being validated (CWE-180, CWE-181). Make sure that your application does not inadvertently decode the same input twice (CWE-174). Such errors could be used to bypass allowlist schemes by introducing dangerous inputs after they have been checked. Use libraries such as the OWASP ESAPI Canonicalization control.
Consider performing repeated canonicalization until your input does not change any more. This will avoid double-decoding and similar scenarios, but it might inadvertently modify inputs that are allowed to contain properly-encoded dangerous content.

NVD	https://nvd.nist.gov/vuln/detail/CVE-2020-5260
CWE	https://cwe.mitre.org/data/definitions/20.html

Improper Input Validation

Weakness

Affected Software

Extended Description

Potential Mitigations

References

CVE-2020-5260

Improper Input Validation

Weakness

Affected Software

Extended Description

Potential Mitigations

Related Attack Patterns

References