CVE-2021-46993

In the Linux kernel, the following vulnerability has been resolved:

sched: Fix out-of-bound access in uclamp

Util-clamp places tasks in different buckets based on their clamp values for performance reasons. However, the size of buckets is currently computed using a rounding division, which can lead to an off-by-one error in some configurations.

For instance, with 20 buckets, the bucket size will be 1024/20=51. A task with a clamp of 1024 will be mapped to bucket id 1024/51=20. Sadly, correct indexes are in range [0,19], hence leading to an out of bound memory access.

Clamp the bucket id to fix the issue.

Weakness

The product reads data past the end, or before the beginning, of the intended buffer.

Affected Software

Potential Mitigations

• Assume all input is malicious. Use an “accept known good” input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does.
• When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, “boat” may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as “red” or “blue.”
• Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code’s environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.
• To reduce the likelihood of introducing an out-of-bounds read, ensure that you validate and ensure correct calculations for any length argument, buffer size calculation, or offset. Be especially careful of relying on a sentinel (i.e. special character such as NUL) in untrusted inputs.

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/540.html

References

• https://git.kernel.org/stable/c/3da3f804b82a0a382d523a21acf4cf3bb35f936d
• https://git.kernel.org/stable/c/42ee47c7e3569d9a0e2cb5053c496d97d380472f
• https://git.kernel.org/stable/c/687f523c134b7f0bd040ee1230f6d17990d54172
• https://git.kernel.org/stable/c/6d2f8909a5fabb73fe2a63918117943986c39b6c
• https://git.kernel.org/stable/c/f7347c85490b92dd144fa1fba9e1eca501656ab3
• https://git.kernel.org/stable/c/3da3f804b82a0a382d523a21acf4cf3bb35f936d
• https://git.kernel.org/stable/c/42ee47c7e3569d9a0e2cb5053c496d97d380472f
• https://git.kernel.org/stable/c/687f523c134b7f0bd040ee1230f6d17990d54172
• https://git.kernel.org/stable/c/6d2f8909a5fabb73fe2a63918117943986c39b6c
• https://git.kernel.org/stable/c/f7347c85490b92dd144fa1fba9e1eca501656ab3