CVE-2021-47203

In the Linux kernel, the following vulnerability has been resolved:

scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq()

When parsing the txq list in lpfc_drain_txq(), the driver attempts to pass the requests to the adapter. If such an attempt fails, a local fail_msg string is set and a log message output. The job is then added to a completions list for cancellation.

Processing of any further jobs from the txq list continues, but since fail_msg remains set, jobs are added to the completions list regardless of whether a wqe was passed to the adapter. If successfully added to txcmplq, jobs are added to both lists resulting in list corruption.

Fix by clearing the fail_msg string after adding a job to the completions list. This stops the subsequent jobs from being added to the completions list unless they had an appropriate failure.

Weakness

The product writes data past the end, or before the beginning, of the intended buffer.

Affected Software

Potential Mitigations

• Use a language that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.

• For example, many languages that perform their own memory management, such as Java and Perl, are not subject to buffer overflows. Other languages, such as Ada and C#, typically provide overflow protection, but the protection can be disabled by the programmer.

• Be wary that a language’s interface to native code may still be subject to overflows, even if the language itself is theoretically safe.

• Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.

• Examples include the Safe C String Library (SafeStr) by Messier and Viega [REF-57], and the Strsafe.h library from Microsoft [REF-56]. These libraries provide safer versions of overflow-prone string-handling functions.

• Use automatic buffer overflow detection mechanisms that are offered by certain compilers or compiler extensions. Examples include: the Microsoft Visual Studio /GS flag, Fedora/Red Hat FORTIFY_SOURCE GCC flag, StackGuard, and ProPolice, which provide various mechanisms including canary-based detection and range/index checking.

• D3-SFCV (Stack Frame Canary Validation) from D3FEND [REF-1334] discusses canary-based detection in detail.

• Consider adhering to the following rules when allocating and managing an application’s memory:

• Run or compile the software using features or extensions that randomly arrange the positions of a program’s executable and libraries in memory. Because this makes the addresses unpredictable, it can prevent an attacker from reliably jumping to exploitable code.

• Examples include Address Space Layout Randomization (ASLR) [REF-58] [REF-60] and Position-Independent Executables (PIE) [REF-64]. Imported modules may be similarly realigned if their default memory addresses conflict with other modules, in a process known as “rebasing” (for Windows) and “prelinking” (for Linux) [REF-1332] using randomly generated addresses. ASLR for libraries cannot be used in conjunction with prelink since it would require relocating the libraries at run-time, defeating the whole purpose of prelinking.

• For more information on these techniques see D3-SAOR (Segment Address Offset Randomization) from D3FEND [REF-1335].

• Use a CPU and operating system that offers Data Execution Protection (using hardware NX or XD bits) or the equivalent techniques that simulate this feature in software, such as PaX [REF-60] [REF-61]. These techniques ensure that any instruction executed is exclusively at a memory address that is part of the code segment.

• For more information on these techniques see D3-PSEP (Process Segment Execution Prevention) from D3FEND [REF-1336].

References

• https://git.kernel.org/stable/c/16bcbfb56d759c25665f786e33ec633b9508a08f
• https://git.kernel.org/stable/c/814d3610c4ce86e8cf285b2cdac0057a42e82de5
• https://git.kernel.org/stable/c/99154581b05c8fb22607afb7c3d66c1bace6aa5d
• https://git.kernel.org/stable/c/ad4776b5eb2e58af1226847fcd3b4f6d051674dd
• https://git.kernel.org/stable/c/b291d147d0268e93ad866f8bc820ea14497abc9b
• https://git.kernel.org/stable/c/c097bd5a59162156d9c2077a2f58732ffbaa9fca
• https://git.kernel.org/stable/c/ec70d80a8642900086447ba0cdc79e3f44d42e8f
• https://git.kernel.org/stable/c/f05a0191b90156e539cccc189b9d87ca2a4d9305
• https://git.kernel.org/stable/c/16bcbfb56d759c25665f786e33ec633b9508a08f
• https://git.kernel.org/stable/c/814d3610c4ce86e8cf285b2cdac0057a42e82de5
• https://git.kernel.org/stable/c/99154581b05c8fb22607afb7c3d66c1bace6aa5d
• https://git.kernel.org/stable/c/ad4776b5eb2e58af1226847fcd3b4f6d051674dd
• https://git.kernel.org/stable/c/b291d147d0268e93ad866f8bc820ea14497abc9b
• https://git.kernel.org/stable/c/c097bd5a59162156d9c2077a2f58732ffbaa9fca
• https://git.kernel.org/stable/c/ec70d80a8642900086447ba0cdc79e3f44d42e8f
• https://git.kernel.org/stable/c/f05a0191b90156e539cccc189b9d87ca2a4d9305