CVE-2023-52847

In the Linux kernel, the following vulnerability has been resolved:

media: bttv: fix use after free error due to btv->timeout timer

There may be some a race condition between timer function bttv_irq_timeout and bttv_remove. The timer is setup in probe and there is no timer_delete operation in remove function. When it hit kfree btv, the function might still be invoked, which will cause use after free bug.

This bug is found by static analysis, it may be false positive.

Fix it by adding del_timer_sync invoking to the remove function.

cpu0 cpu1 bttv_probe ->timer_setup ->bttv_set_dma ->mod_timer; bttv_remove ->kfree(btv); ->bttv_irq_timeout ->USE btv

Weakness

The product contains a concurrent code sequence that requires temporary, exclusive access to a shared resource, but a timing window exists in which the shared resource can be modified by another code sequence operating concurrently.

Affected Software

Extended Description

A race condition occurs within concurrent environments, and it is effectively a property of a code sequence. Depending on the context, a code sequence may be in the form of a function call, a small number of instructions, a series of program invocations, etc. A race condition violates these properties, which are closely related:

A race condition exists when an “interfering code sequence” can still access the shared resource, violating exclusivity. The interfering code sequence could be “trusted” or “untrusted.” A trusted interfering code sequence occurs within the product; it cannot be modified by the attacker, and it can only be invoked indirectly. An untrusted interfering code sequence can be authored directly by the attacker, and typically it is external to the vulnerable product.

Potential Mitigations

• Minimize the usage of shared resources in order to remove as much complexity as possible from the control flow and to reduce the likelihood of unexpected conditions occurring.
• Additionally, this will minimize the amount of synchronization necessary and may even help to reduce the likelihood of a denial of service where an attacker may be able to repeatedly trigger a critical section (CWE-400).

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/26.html
• https://cwe.mitre.org/data/definitions/29.html

References

• https://git.kernel.org/stable/c/1871014d6ef4812ad11ef7d838d73ce09d632267
• https://git.kernel.org/stable/c/20568d06f6069cb835e05eed432edf962645d226
• https://git.kernel.org/stable/c/2f3d9198cdae1cb079ec8652f4defacd481eab2b
• https://git.kernel.org/stable/c/51c94256a83fe4e17406c66ff3e1ad7d242d8574
• https://git.kernel.org/stable/c/847599fffa528b2cdec4e21b6bf7586dad982132
• https://git.kernel.org/stable/c/b35fdade92c5058a5e727e233fe263b828de2c9a
• https://git.kernel.org/stable/c/bbc3b8dd2cb7817e703f112d988e4f4728f0f2a9
• https://git.kernel.org/stable/c/bd5b50b329e850d467e7bcc07b2b6bde3752fbda
• https://git.kernel.org/stable/c/1871014d6ef4812ad11ef7d838d73ce09d632267
• https://git.kernel.org/stable/c/20568d06f6069cb835e05eed432edf962645d226
• https://git.kernel.org/stable/c/2f3d9198cdae1cb079ec8652f4defacd481eab2b
• https://git.kernel.org/stable/c/51c94256a83fe4e17406c66ff3e1ad7d242d8574
• https://git.kernel.org/stable/c/847599fffa528b2cdec4e21b6bf7586dad982132
• https://git.kernel.org/stable/c/b35fdade92c5058a5e727e233fe263b828de2c9a
• https://git.kernel.org/stable/c/bbc3b8dd2cb7817e703f112d988e4f4728f0f2a9
• https://git.kernel.org/stable/c/bd5b50b329e850d467e7bcc07b2b6bde3752fbda