CVE-2023-53624

In the Linux kernel, the following vulnerability has been resolved:

net/sched: sch_fq: fix integer overflow of credit

if sch_fq is configured with initial quantum having values greater than INT_MAX, the first assignment of credit does signed integer overflow to a very negative value. In this situation, the syzkaller script provided by Cristoph triggers the CPU soft-lockup warning even with few sockets. Its not an infinite loop, but credit wasnt probably meant to be minus 2Gb for each new flow. Capping initial quantum to INT_MAX proved to fix the issue.

v2: validation of initial quantum is done in fq_policy, instead of open coding in fq_change() _ suggested by Jakub Kicinski

Weakness

The product performs a calculation that can produce an integer overflow or wraparound when the logic assumes that the resulting value will always be larger than the original value. This occurs when an integer value is incremented to a value that is too large to store in the associated representation. When this occurs, the value may become a very small or negative number.

Affected Software

Potential Mitigations

• Use a language that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.
• If possible, choose a language or compiler that performs automatic bounds checking.
• Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid [REF-1482].
• Use libraries or frameworks that make it easier to handle numbers without unexpected consequences.
• Examples include safe integer handling packages such as SafeInt (C++) or IntegerLib (C or C++). [REF-106]
• Perform input validation on any numeric input by ensuring that it is within the expected range. Enforce that the input meets both the minimum and maximum requirements for the expected range.
• Use unsigned integers where possible. This makes it easier to perform validation for integer overflows. When signed integers are required, ensure that the range check includes minimum values as well as maximum values.
• Understand the programming language’s underlying representation and how it interacts with numeric calculation (CWE-681). Pay close attention to byte size discrepancies, precision, signed/unsigned distinctions, truncation, conversion and casting between types, “not-a-number” calculations, and how the language handles numbers that are too large or too small for its underlying representation. [REF-7]
• Also be careful to account for 32-bit, 64-bit, and other potential differences that may affect the numeric representation.

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/92.html

References

• https://git.kernel.org/stable/c/2322462d6f9ad4874f4e3c63df3b5cc00cb1acbd
• https://git.kernel.org/stable/c/4b8a05e3801661a0438fcd0cdef181030d966a5a
• https://git.kernel.org/stable/c/4fbefeab88c6e79753a25099d455d3d59d2946b4
• https://git.kernel.org/stable/c/7041101ff6c3073fd8f2e99920f535b111c929cb
• https://git.kernel.org/stable/c/85f24cb2f10b2b0f2882e5786a09b4790bb3a0ad
• https://git.kernel.org/stable/c/d0b43125ec892aeb1b03e5df5aab595097da225a