A path traversal vulnerability exists in rsync. It stems from behavior enabled by the --inc-recursive option, a default-enabled option for many client options and can be enabled by the server even if not explicitly enabled by the client. When using the --inc-recursive option, a lack of proper symlink verification coupled with deduplication checks occurring on a per-file-list basis could allow a server to write files outside of the clients intended destination directory. A malicious server could write malicious files to arbitrary locations named after valid directories/paths on the client.
Weakness
The product uses external input to construct a pathname that should be within a restricted directory, but it does not properly neutralize ‘…/…//’ (doubled triple dot slash) sequences that can resolve to a location that is outside of that directory.
Affected Software
| Name |
Vendor |
Start Version |
End Version |
| Rsync |
Samba |
* |
3.3.0 (including) |
| Red Hat Enterprise Linux 8 |
RedHat |
rsync-0:3.1.3-21.el8_10 |
* |
| Red Hat Enterprise Linux 9 |
RedHat |
rsync-0:3.2.5-3.el9 |
* |
| Red Hat Enterprise Linux 9 |
RedHat |
rsync-0:3.2.5-3.el9 |
* |
| Red Hat Discovery 1.14 |
RedHat |
registry.redhat.io/discovery/discovery-ui-rhel9:sha256:492e412759cf0eedfa5b557f7b0865f8864f84d0ed75e11dc8d7a840837d9644 |
* |
| Rsync |
Ubuntu |
devel |
* |
| Rsync |
Ubuntu |
esm-infra-legacy/trusty |
* |
| Rsync |
Ubuntu |
esm-infra/bionic |
* |
| Rsync |
Ubuntu |
esm-infra/xenial |
* |
| Rsync |
Ubuntu |
focal |
* |
| Rsync |
Ubuntu |
jammy |
* |
| Rsync |
Ubuntu |
noble |
* |
| Rsync |
Ubuntu |
oracular |
* |
| Rsync |
Ubuntu |
trusty/esm |
* |
| Rsync |
Ubuntu |
upstream |
* |
Extended Description
This allows attackers to traverse the file system to access files or directories that are outside of the restricted directory.
The ‘…/…//’ manipulation is useful for bypassing some path traversal protection schemes. If “../” is filtered in a sequential fashion, as done by some regular expression engines, then “…/…//” can collapse into the “../” unsafe value (CWE-182). Removing the first “../” yields “….//”; the second removal yields “../”. Depending on the algorithm, the product could be susceptible to CWE-34 but not CWE-35, or vice versa.
Potential Mitigations
- Assume all input is malicious. Use an “accept known good” input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does.
- When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, “boat” may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as “red” or “blue.”
- Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code’s environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.
- When validating filenames, use stringent allowlists that limit the character set to be used. If feasible, only allow a single “.” character in the filename to avoid weaknesses such as CWE-23, and exclude directory separators such as “/” to avoid CWE-36. Use a list of allowable file extensions, which will help to avoid CWE-434.
- Do not rely exclusively on a filtering mechanism that removes potentially dangerous characters. This is equivalent to a denylist, which may be incomplete (CWE-184). For example, filtering “/” is insufficient protection if the filesystem also supports the use of “" as a directory separator. Another possible error could occur when the filtering is applied in a way that still produces dangerous data (CWE-182). For example, if “../” sequences are removed from the “…/…//” string in a sequential fashion, two instances of “../” would be removed from the original string, but the remaining characters would still form the “../” string.
References