CVE-2024-26791

In the Linux kernel, the following vulnerability has been resolved:

btrfs: dev-replace: properly validate device names

Theres a syzbot report that device name buffers passed to device replace are not properly checked for string termination which could lead to a read out of bounds in getname_kernel().

Add a helper that validates both source and target device name buffers. For devid as the source initialize the buffer to empty string in case something tries to read it later.

This was originally analyzed and fixed in a different way by Edward Adam Davis (see links).

Weakness

The product reads data past the end, or before the beginning, of the intended buffer.

Affected Software

Potential Mitigations

• Assume all input is malicious. Use an “accept known good” input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does.
• When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, “boat” may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as “red” or “blue.”
• Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code’s environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.
• To reduce the likelihood of introducing an out-of-bounds read, ensure that you validate and ensure correct calculations for any length argument, buffer size calculation, or offset. Be especially careful of relying on a sentinel (i.e. special character such as NUL) in untrusted inputs.

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/540.html

References

• https://git.kernel.org/stable/c/11d7a2e429c02d51e2dc90713823ea8b8d3d3a84
• https://git.kernel.org/stable/c/2886fe308a83968dde252302884a1e63351cf16d
• https://git.kernel.org/stable/c/343eecb4ff49a7b1cc1dfe86958a805cf2341cfb
• https://git.kernel.org/stable/c/9845664b9ee47ce7ee7ea93caf47d39a9d4552c4
• https://git.kernel.org/stable/c/ab2d68655d0f04650bef09fee948ff80597c5fb9
• https://git.kernel.org/stable/c/b1690ced4d2d8b28868811fb81cd33eee5aefee1
• https://git.kernel.org/stable/c/c6652e20d7d783d060fe5f987eac7b5cabe31311
• https://git.kernel.org/stable/c/f590040ce2b712177306b03c2a63b16f7d48d3c8
• https://git.kernel.org/stable/c/11d7a2e429c02d51e2dc90713823ea8b8d3d3a84
• https://git.kernel.org/stable/c/2886fe308a83968dde252302884a1e63351cf16d
• https://git.kernel.org/stable/c/343eecb4ff49a7b1cc1dfe86958a805cf2341cfb
• https://git.kernel.org/stable/c/9845664b9ee47ce7ee7ea93caf47d39a9d4552c4
• https://git.kernel.org/stable/c/ab2d68655d0f04650bef09fee948ff80597c5fb9
• https://git.kernel.org/stable/c/b1690ced4d2d8b28868811fb81cd33eee5aefee1
• https://git.kernel.org/stable/c/c6652e20d7d783d060fe5f987eac7b5cabe31311
• https://git.kernel.org/stable/c/f590040ce2b712177306b03c2a63b16f7d48d3c8
• https://lists.debian.org/debian-lts-announce/2024/06/msg00017.html
• https://lists.debian.org/debian-lts-announce/2024/06/msg00020.html