CVE-2024-26878

In the Linux kernel, the following vulnerability has been resolved:

quota: Fix potential NULL pointer dereference

Below race may cause NULL pointer dereference

P1 P2 dquot_free_inode quota_off drop_dquot_ref remove_dquot_ref dquots = i_dquot(inode) dquots = i_dquot(inode) srcu_read_lock dquots[cnt]) != NULL (1) dquots[type] = NULL (2) spin_lock(&dquots[cnt]->dq_dqb_lock) (3) ….

If dquot_free_inode(or other routines) checks inodes quota pointers (1) before quota_off sets it to NULL(2) and use it (3) after that, NULL pointer dereference will be triggered.

So lets fix it by using a temporary pointer to avoid this issue.

Weakness

The product contains a concurrent code sequence that requires temporary, exclusive access to a shared resource, but a timing window exists in which the shared resource can be modified by another code sequence operating concurrently.

Affected Software

Extended Description

A race condition occurs within concurrent environments, and it is effectively a property of a code sequence. Depending on the context, a code sequence may be in the form of a function call, a small number of instructions, a series of program invocations, etc. A race condition violates these properties, which are closely related:

A race condition exists when an “interfering code sequence” can still access the shared resource, violating exclusivity. The interfering code sequence could be “trusted” or “untrusted.” A trusted interfering code sequence occurs within the product; it cannot be modified by the attacker, and it can only be invoked indirectly. An untrusted interfering code sequence can be authored directly by the attacker, and typically it is external to the vulnerable product.

Potential Mitigations

• Minimize the usage of shared resources in order to remove as much complexity as possible from the control flow and to reduce the likelihood of unexpected conditions occurring.
• Additionally, this will minimize the amount of synchronization necessary and may even help to reduce the likelihood of a denial of service where an attacker may be able to repeatedly trigger a critical section (CWE-400).

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/26.html
• https://cwe.mitre.org/data/definitions/29.html

References

• https://git.kernel.org/stable/c/1ca72a3de915f87232c9a4cb9bebbd3af8ed3e25
• https://git.kernel.org/stable/c/40a673b4b07efd6f74ff3ab60f38b26aa91ee5d5
• https://git.kernel.org/stable/c/49669f8e7eb053f91d239df7b1bfb4500255a9d0
• https://git.kernel.org/stable/c/61380537aa6dd32d8a723d98b8f1bd1b11d8fee0
• https://git.kernel.org/stable/c/6afc9f4434fa8063aa768c2bf5bf98583aee0877
• https://git.kernel.org/stable/c/7f9e833fc0f9b47be503af012eb5903086939754
• https://git.kernel.org/stable/c/8514899c1a4edf802f03c408db901063aa3f05a1
• https://git.kernel.org/stable/c/d0aa72604fbd80c8aabb46eda00535ed35570f1f
• https://git.kernel.org/stable/c/f2649d98aa9ca8623149b3cb8df00c944f5655c7
• https://git.kernel.org/stable/c/1ca72a3de915f87232c9a4cb9bebbd3af8ed3e25
• https://git.kernel.org/stable/c/40a673b4b07efd6f74ff3ab60f38b26aa91ee5d5
• https://git.kernel.org/stable/c/49669f8e7eb053f91d239df7b1bfb4500255a9d0
• https://git.kernel.org/stable/c/61380537aa6dd32d8a723d98b8f1bd1b11d8fee0
• https://git.kernel.org/stable/c/6afc9f4434fa8063aa768c2bf5bf98583aee0877
• https://git.kernel.org/stable/c/7f9e833fc0f9b47be503af012eb5903086939754
• https://git.kernel.org/stable/c/8514899c1a4edf802f03c408db901063aa3f05a1
• https://git.kernel.org/stable/c/d0aa72604fbd80c8aabb46eda00535ed35570f1f
• https://git.kernel.org/stable/c/f2649d98aa9ca8623149b3cb8df00c944f5655c7
• https://lists.debian.org/debian-lts-announce/2024/06/msg00017.html
• https://lists.debian.org/debian-lts-announce/2024/06/msg00020.html