CVE-2024-30252

Livemarks is a browser extension that provides RSS feed bookmark folders. Versions of Livemarks prior to 3.7 are vulnerable to cross-site request forgery. A malicious website may be able to coerce the extension to send an authenticated GET request to an arbitrary URL. An authenticated request is a request where the cookies of the browser are sent along with the request. The subscribe.js script uses the first parameter from the current URL location as the URL of the RSS feed to subscribe to and checks that the RSS feed is valid XML. subscribe.js is accessible by an attacker website due to its use in subscribe.html, an HTML page that is declared as a web_accessible_resource in manifest.json. This issue may lead to Privilege Escalation. A CSRF breaks the integrity of servers running on a private network. A user of the browser extension may have a private server with dangerous functionality, which is assumed to be safe due to network segmentation. Upon receiving an authenticated request instantiated from an attacker, this integrity is broken. Version 3.7 fixes this issue by removing subscribe.html from web_accessible_resources.

Weakness

The web application does not, or can not, sufficiently verify whether a well-formed, valid, consistent request was intentionally provided by the user who submitted the request.

Potential Mitigations

• Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.
• For example, use anti-CSRF packages such as the OWASP CSRFGuard. [REF-330]
• Another example is the ESAPI Session Management control, which includes a component for CSRF. [REF-45]
• Use the “double-submitted cookie” method as described by Felten and Zeller:
• When a user visits a site, the site should generate a pseudorandom value and set it as a cookie on the user’s machine. The site should require every form submission to include this value as a form value and also as a cookie value. When a POST request is sent to the site, the request should only be considered valid if the form value and the cookie value are the same.
• Because of the same-origin policy, an attacker cannot read or modify the value stored in the cookie. To successfully submit a form on behalf of the user, the attacker would have to correctly guess the pseudorandom value. If the pseudorandom value is cryptographically strong, this will be prohibitively difficult.
• This technique requires Javascript, so it may not work for browsers that have Javascript disabled. [REF-331]

Related Attack Patterns

• https://cwe.mitre.org/data/definitions/111.html
• https://cwe.mitre.org/data/definitions/462.html
• https://cwe.mitre.org/data/definitions/467.html
• https://cwe.mitre.org/data/definitions/62.html

References

• https://github.com/nt1m/livemarks/blob/9c5233c82aa2f7c8bac348a08ff52881b00c4f95/manifest.json#L4
• https://github.com/nt1m/livemarks/blob/9c5233c82aa2f7c8bac348a08ff52881b00c4f95/pages/subscribe/subscribe.js#L52
• https://github.com/nt1m/livemarks/blob/9c5233c82aa2f7c8bac348a08ff52881b00c4f95/shared/feed-parser.js#L5
• https://github.com/nt1m/livemarks/commit/1bcf39f6e91f7352301013f8feac6d488719450f
• https://github.com/nt1m/livemarks/security/advisories/GHSA-3gg9-w4fm-jjcg