CVE-2025-21721

In the Linux kernel, the following vulnerability has been resolved:

nilfs2: handle errors that nilfs_prepare_chunk() may return

Patch series nilfs2: fix issues with rename operations.

This series fixes BUG_ON check failures reported by syzbot around rename operations, and a minor behavioral issue where the mtime of a child directory changes when it is renamed instead of moved.

This patch (of 2):

The directory manipulation routines nilfs_set_link() and nilfs_delete_entry() rewrite the directory entry in the folio/page previously read by nilfs_find_entry(), so error handling is omitted on the assumption that nilfs_prepare_chunk(), which prepares the buffer for rewriting, will always succeed for these. And if an error is returned, it triggers the legacy BUG_ON() checks in each routine.

This assumption is wrong, as proven by syzbot: the buffer layer called by nilfs_prepare_chunk() may call nilfs_get_block() if necessary, which may fail due to metadata corruption or other reasons. This has been there all along, but improved sanity checks and error handling may have made it more reproducible in fuzzing tests.

Fix this issue by adding missing error paths in nilfs_set_link(), nilfs_delete_entry(), and their caller nilfs_rename().

Weakness

The product contains an assert() or similar statement that can be triggered by an attacker, which leads to an application exit or other behavior that is more severe than necessary.

Affected Software

Extended Description

While assertion is good for catching logic errors and reducing the chances of reaching more serious vulnerability conditions, it can still lead to a denial of service. For example, if a server handles multiple simultaneous connections, and an assert() occurs in one single connection that causes all other connections to be dropped, this is a reachable assertion that leads to a denial of service.

Potential Mitigations

References

• https://git.kernel.org/stable/c/1ee2d454baa361d2964e3e2f2cca9ee3f769d93c
• https://git.kernel.org/stable/c/481136234dfe96c7f92770829bec6111c7c5f5dd
• https://git.kernel.org/stable/c/607dc724b162f4452dc768865e578c1a509a1c8c
• https://git.kernel.org/stable/c/7891ac3b0a5c56f7148af507306308ab841cdc31
• https://git.kernel.org/stable/c/b38c6c260c2415c7f0968871305e7a093daabb4c
• https://git.kernel.org/stable/c/eddd3176b8c4c83a46ab974574cda7c3dfe09388
• https://git.kernel.org/stable/c/ee70999a988b8abc3490609142f50ebaa8344432
• https://git.kernel.org/stable/c/f70bd2d8ca454e0ed78970f72147ca321dbaa015