ssh in OpenSSH before 10.1 allows control characters in usernames that originate from certain possibly untrusted sources, potentially leading to code execution when a ProxyCommand is used. The untrusted sources are the command line and %-sequence expansion of a configuration file. (A configuration file that provides a complete literal username is not categorized as an untrusted source.)
Weakness
The product does not properly filter, remove, quote, or otherwise manage the invalid use of special elements in user-controlled input, which could cause adverse effect on its behavior and integrity.
Affected Software
Name |
Vendor |
Start Version |
End Version |
Openssh |
Ubuntu |
upstream |
* |
Openssh-ssh1 |
Ubuntu |
devel |
* |
Openssh-ssh1 |
Ubuntu |
esm-apps/focal |
* |
Openssh-ssh1 |
Ubuntu |
esm-apps/jammy |
* |
Openssh-ssh1 |
Ubuntu |
esm-apps/noble |
* |
Openssh-ssh1 |
Ubuntu |
jammy |
* |
Openssh-ssh1 |
Ubuntu |
noble |
* |
Openssh-ssh1 |
Ubuntu |
plucky |
* |
Openssh-ssh1 |
Ubuntu |
questing |
* |
Openssh-ssh1 |
Ubuntu |
upstream |
* |
Potential Mitigations
- Assume all input is malicious. Use an “accept known good” input validation strategy, i.e., use a list of acceptable inputs that strictly conform to specifications. Reject any input that does not strictly conform to specifications, or transform it into something that does.
- When performing input validation, consider all potentially relevant properties, including length, type of input, the full range of acceptable values, missing or extra inputs, syntax, consistency across related fields, and conformance to business rules. As an example of business rule logic, “boat” may be syntactically valid because it only contains alphanumeric characters, but it is not valid if the input is only expected to contain colors such as “red” or “blue.”
- Do not rely exclusively on looking for malicious or malformed inputs. This is likely to miss at least one undesirable input, especially if the code’s environment changes. This can give attackers enough room to bypass the intended validation. However, denylists can be useful for detecting potential attacks or determining which inputs are so malformed that they should be rejected outright.
References