Zulip is an open-source team collaboration tool. In Zulip Server versions through 12.1, guest users can receive new message events for public channels outside their subscriptions. A guest can trigger the issue by registering an event queue with parameters that request messages from an unsubscribed public channel, or an existing event queue can remain affected after the guests access to the channel is removed. The flaw discloses new public-channel messages to the guest. This issue is fixed in version 12.2.
Weakness
The product does not perform an authorization check when an actor attempts to access a resource or perform an action.
Potential Mitigations
- Divide the product into anonymous, normal, privileged, and administrative areas. Reduce the attack surface by carefully mapping roles with data and functionality. Use role-based access control (RBAC) [REF-229] to enforce the roles at the appropriate boundaries.
- Note that this approach may not protect against horizontal authorization, i.e., it will not protect a user from attacking others with the same role.
- Use a vetted library or framework that does not allow this weakness to occur or provides constructs that make this weakness easier to avoid.
- For example, consider using authorization frameworks such as the JAAS Authorization Framework [REF-233] and the OWASP ESAPI Access Control feature [REF-45].
- For web applications, make sure that the access control mechanism is enforced correctly at the server side on every page. Users should not be able to access any unauthorized functionality or information by simply requesting direct access to that page.
- One way to do this is to ensure that all pages containing sensitive information are not cached, and that all such pages restrict access to requests that are accompanied by an active and authenticated session token associated with a user who has the required permissions to access that page.
Related Attack Patterns
References
- https://github.com/zulip/zulip/commit/98659a41cb93d4ce329ea14bb0cdfb4b147500ba
- https://github.com/zulip/zulip/commit/c03db8916456674df3c98614f6f0ef8cd024ef11
- https://github.com/zulip/zulip/pull/39913
- https://github.com/zulip/zulip/releases/tag/12.2
- https://github.com/zulip/zulip/security/advisories/GHSA-5r8f-gq2h-fcgp