Gogs is an open source self-hosted Git service. Versions 0.13.4 and below have a broken access control vulnerability which allows authenticated users with write access to any repository to modify labels belonging to other repositories. The UpdateLabel function in the Web UI (internal/route/repo/issue.go) fails to verify that the label being modified belongs to the repository specified in the URL path, enabling cross-repository label tampering attacks. The vulnerability exists in the Web UIs label update endpoint POST /:username/:reponame/labels/edit. The handler function UpdateLabel uses an incorrect database query function that bypasses repository ownership validation. This issue has been fixed in version 0.14.1.
Weakness
The product does not restrict or incorrectly restricts access to a resource from an unauthorized actor.
Affected Software
| Name | Vendor | Start Version | End Version |
|---|---|---|---|
| Gogs | Gogs | * | 0.14.1 (excluding) |
Extended Description
Access control involves the use of several protection mechanisms such as:
When any mechanism is not applied or otherwise fails, attackers can compromise the security of the product by gaining privileges, reading sensitive information, executing commands, evading detection, etc. There are two distinct behaviors that can introduce access control weaknesses:
Potential Mitigations
- Compartmentalize the system to have “safe” areas where trust boundaries can be unambiguously drawn. Do not allow sensitive data to go outside of the trust boundary and always be careful when interfacing with a compartment outside of the safe area.
- Ensure that appropriate compartmentalization is built into the system design, and the compartmentalization allows for and reinforces privilege separation functionality. Architects and designers should rely on the principle of least privilege to decide the appropriate time to use privileges and the time to drop privileges.
Related Attack Patterns
- https://cwe.mitre.org/data/definitions/19.html
- https://cwe.mitre.org/data/definitions/441.html
- https://cwe.mitre.org/data/definitions/478.html
- https://cwe.mitre.org/data/definitions/479.html
- https://cwe.mitre.org/data/definitions/502.html
- https://cwe.mitre.org/data/definitions/503.html
- https://cwe.mitre.org/data/definitions/536.html
- https://cwe.mitre.org/data/definitions/546.html
- https://cwe.mitre.org/data/definitions/550.html
- https://cwe.mitre.org/data/definitions/551.html
- https://cwe.mitre.org/data/definitions/552.html
- https://cwe.mitre.org/data/definitions/556.html
- https://cwe.mitre.org/data/definitions/558.html
- https://cwe.mitre.org/data/definitions/562.html
- https://cwe.mitre.org/data/definitions/563.html
- https://cwe.mitre.org/data/definitions/564.html
- https://cwe.mitre.org/data/definitions/578.html