Windmill is an open-source developer platform for internal code: APIs, background jobs, workflows and UIs. Versions 1.634.6 and below allow non-admin users to obtain Slack OAuth client secrets, which should only be accessible to workspace administrators. The GET /api/w/{workspace}/workspaces/get_settings endpoint returns the slack_oauth_client_secret to any authenticated workspace member, regardless of their admin status. It is expected behavior for non-admin users see a redacted version of workspace settings, as some of them are necessary for the frontend to behave correctly even for non-admins. However, the Slack configuration should not be visible to non-admins. This is a legacy issue where the setting was stored as a plain value instead of using $variable indirection, and it was never added to the redaction logic. This issue has been fixed in version 1.635.0.
Weakness
The product exposes sensitive information to an actor that is not explicitly authorized to have access to that information.
Extended Description
There are many different kinds of mistakes that introduce information exposures. The severity of the error can range widely, depending on the context in which the product operates, the type of sensitive information that is revealed, and the benefits it may provide to an attacker. Some kinds of sensitive information include:
Information might be sensitive to different parties, each of which may have their own expectations for whether the information should be protected. These parties include:
Information exposures can occur in different ways:
It is common practice to describe any loss of confidentiality as an “information exposure,” but this can lead to overuse of CWE-200 in CWE mapping. From the CWE perspective, loss of confidentiality is a technical impact that can arise from dozens of different weaknesses, such as insecure file permissions or out-of-bounds read. CWE-200 and its lower-level descendants are intended to cover the mistakes that occur in behaviors that explicitly manage, store, transfer, or cleanse sensitive information.
Potential Mitigations
- Compartmentalize the system to have “safe” areas where trust boundaries can be unambiguously drawn. Do not allow sensitive data to go outside of the trust boundary and always be careful when interfacing with a compartment outside of the safe area.
- Ensure that appropriate compartmentalization is built into the system design, and the compartmentalization allows for and reinforces privilege separation functionality. Architects and designers should rely on the principle of least privilege to decide the appropriate time to use privileges and the time to drop privileges.
Related Attack Patterns
- https://cwe.mitre.org/data/definitions/116.html
- https://cwe.mitre.org/data/definitions/13.html
- https://cwe.mitre.org/data/definitions/169.html
- https://cwe.mitre.org/data/definitions/22.html
- https://cwe.mitre.org/data/definitions/224.html
- https://cwe.mitre.org/data/definitions/285.html
- https://cwe.mitre.org/data/definitions/287.html
- https://cwe.mitre.org/data/definitions/290.html
- https://cwe.mitre.org/data/definitions/291.html
- https://cwe.mitre.org/data/definitions/292.html
- https://cwe.mitre.org/data/definitions/293.html
- https://cwe.mitre.org/data/definitions/294.html
- https://cwe.mitre.org/data/definitions/295.html
- https://cwe.mitre.org/data/definitions/296.html
- https://cwe.mitre.org/data/definitions/297.html
- https://cwe.mitre.org/data/definitions/298.html
- https://cwe.mitre.org/data/definitions/299.html
- https://cwe.mitre.org/data/definitions/300.html
- https://cwe.mitre.org/data/definitions/301.html
- https://cwe.mitre.org/data/definitions/302.html
- https://cwe.mitre.org/data/definitions/303.html
- https://cwe.mitre.org/data/definitions/304.html
- https://cwe.mitre.org/data/definitions/305.html
- https://cwe.mitre.org/data/definitions/306.html
- https://cwe.mitre.org/data/definitions/307.html
- https://cwe.mitre.org/data/definitions/308.html
- https://cwe.mitre.org/data/definitions/309.html
- https://cwe.mitre.org/data/definitions/310.html
- https://cwe.mitre.org/data/definitions/312.html
- https://cwe.mitre.org/data/definitions/313.html
- https://cwe.mitre.org/data/definitions/317.html
- https://cwe.mitre.org/data/definitions/318.html
- https://cwe.mitre.org/data/definitions/319.html
- https://cwe.mitre.org/data/definitions/320.html
- https://cwe.mitre.org/data/definitions/321.html
- https://cwe.mitre.org/data/definitions/322.html
- https://cwe.mitre.org/data/definitions/323.html
- https://cwe.mitre.org/data/definitions/324.html
- https://cwe.mitre.org/data/definitions/325.html
- https://cwe.mitre.org/data/definitions/326.html
- https://cwe.mitre.org/data/definitions/327.html
- https://cwe.mitre.org/data/definitions/328.html
- https://cwe.mitre.org/data/definitions/329.html
- https://cwe.mitre.org/data/definitions/330.html
- https://cwe.mitre.org/data/definitions/472.html
- https://cwe.mitre.org/data/definitions/497.html
- https://cwe.mitre.org/data/definitions/508.html
- https://cwe.mitre.org/data/definitions/573.html
- https://cwe.mitre.org/data/definitions/574.html
- https://cwe.mitre.org/data/definitions/575.html
- https://cwe.mitre.org/data/definitions/576.html
- https://cwe.mitre.org/data/definitions/577.html
- https://cwe.mitre.org/data/definitions/59.html
- https://cwe.mitre.org/data/definitions/60.html
- https://cwe.mitre.org/data/definitions/616.html
- https://cwe.mitre.org/data/definitions/643.html
- https://cwe.mitre.org/data/definitions/646.html
- https://cwe.mitre.org/data/definitions/651.html
- https://cwe.mitre.org/data/definitions/79.html