In the Linux kernel, the following vulnerability has been resolved:
dm thin metadata: fix metadata snapshot consistency on commit failure
__reserve_metadata_snap() and __release_metadata_snap() modify the superblocks held_root directly in the block_managers buffer. If the subsequent metadata commit fails, the held_root gets flushed to disk through the abort_transaction path, resulting in inconsistent metadata.
Reproducer 1: __reserve_metadata_snap()
dmsetup create tmeta –table 0 112 linear /dev/sdc 0 112 3984 error
dmsetup create tdata –table 0 32768 zero dd if=/dev/zero of=/dev/mapper/tmeta bs=4k count=1 dmsetup create tpool –table 0 32768 thin-pool /dev/mapper/tmeta /dev/mapper/tdata 128 0 1 skip_block_zeroing
dmsetup message tpool 0 reserve_metadata_snap
thin_check v1.2.2 result:
Bad reference count for metadata block 6. Expected 2, but space map contains 1. Bad reference count for metadata block 7. Expected 2, but space map contains 1. Bad reference count for metadata block 13. Expected 1, but space map contains 0.
Reproducer 2: __release_metadata_snap()
dmsetup create tmeta –table 0 128 linear /dev/sdc 0 128 3968 error
dmsetup create tdata –table 0 32768 zero dd if=/dev/zero of=/dev/mapper/tmeta bs=4k count=1 dmsetup create tpool –table 0 32768 thin-pool /dev/mapper/tmeta /dev/mapper/tdata 128 0 1 skip_block_zeroing
dmsetup message tpool 0 reserve_metadata_snap dmsetup message tpool 0 release_metadata_snap
thin_check v1.2.2 result:
Bad reference count for metadata block 6. Expected 1, but space map contains 2. Bad reference count for metadata block 7. Expected 1, but space map contains 2. 1 metadata blocks have leaked.
Fix by deferring the held_root update to commit time.
Additionally, move the existing-snapshot check in __reserve_metadata_snap before the shadow operation to avoid unnecessary work. In __release_metadata_snap, clear pmd->held_root before btree deletion so partial failure leaks blocks rather than leaving a stale reference, and unlock the snapshot block before decrementing its refcount.